Create typing hints for IUIAutomationTextRange#13903
Merged
Merged
Conversation
feerrenrut
approved these changes
Jul 15, 2022
| class _IUIAutomationTextRangeT(Protocol): | ||
| # Based on IUIAutomationTextRange | ||
| # https://docs.microsoft.com/en-us/windows/win32/api/uiautomationclient/nn-uiautomationclient-iuiautomationtextrange | ||
| # Currently incomplete. |
Contributor
There was a problem hiding this comment.
Might be worth trying this:
https://mypy.readthedocs.io/en/stable/stubgen.html
Member
Author
There was a problem hiding this comment.
Unfortunately this did not generate helpful types.
The comInterfaces code in _944DE083_8FB8_45CF_BCB7_C477ACB2F897_0_1_0.py does not provide a lot of type information.
class IUIAutomationTextRange(comtypes.gen._00020430_0000_0000_C000_000000000046_0_2_0.IUnknown):
_case_insensitive_ = True
_iid_ = GUID('{A543CC6A-F4AE-494B-8239-C814481187A8}')
_idlflags_ = []Running stubgen produces nothing helpful.
stubgen -m source.comInterfaces._944DE083_8FB8_45CF_BCB7_C477ACB2F897_0_1_0
Output:
class IUIAutomationTextRange(comtypes.gen._00020430_0000_0000_C000_000000000046_0_2_0.IUnknown): ...
class IUIAutomationTextRangeArray(comtypes.gen._00020430_0000_0000_C000_000000000046_0_2_0.IUnknown): ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
Objects from
comInterfacesgenerally do not have helpful type hints.Description of user facing changes
When a variable is type hinted with
IUIAutomationTextRangeTsupported functions will appear as type hints.Description of development approach
Implements methods found in https://docs.microsoft.com/en-us/windows/win32/api/uiautomationclient/nn-uiautomationclient-iuiautomationtextrange, checked against usages in NVDA code.
Testing strategy:
Known issues with pull request:
Change log entries:
Code Review Checklist: