Fix UIATextInfo and MSHTMLTextInfo, updateCaret without selecting text#13902
Merged
Conversation
feerrenrut
reviewed
Jul 14, 2022
Member
Author
|
Note that this issue can be reproduced with Internet Explorer as well |
Member
Author
|
I've checked all instances of |
feerrenrut
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13899
Summary of the issue:
Using Notepad on Windows 11, performing Say All (
nvda+downArrow|nvda+a) selects each line of text.This is because
UIATextInfo.updateCaret = UIATextInfo.updateSelection, so updating the caret sets the selection.The same problem exists with
MSHTMLTextInfoDescription of user facing changes
Say All no longer highlights each line of text.
Description of development approach
Testing strategy:
Test with STR in #13899 with Notepad
Test Say All with Internet Explorer as well.
Known issues with pull request:
Change log entries:
Fixes unreleased regression
Code Review Checklist: