Added a margin to the browseable message.#13885
Merged
Merged
Conversation
Member
|
When this is ready, would you be able to add screenshots of the change in appearance? |
d85c355 to
911467d
Compare
Contributor
Author
Done. |
Member
|
Thanks @CyrilleB79 - the screenshots look good |
Member
|
I tested this using Arabic as an RTL language, it appears that browseableMessage does not respect RTL layout. |
seanbudd
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The
ui.browseableMessagehas no margin. For people with visual difficulties, it makes more difficult to isolate the content of the browseable message from the text present in the background around the browseable message.Description of user facing changes
The content of browseable message such as formatting information (double press of NVDA+F) is now rendered with a margin around the text.
Description of development approach
Just added the following style property to the message's body:
style="margin:1em"The
1emmeasurement should correspond to 1 character.Note for reviewers:
I know almost nothing in CSS and styles. Thus feel free to suggest something else if the way the margin is implemented is not the best solution.
Testing strategy:
Before (NVDA 2022.2beta3):

After (with this PR):

Known issues with pull request:
The right margin does not seem to appear. Maybe due to the
<pre>tag in theui.browseableMessagefunction?Anyway, the most important margin is the left one, at least for left-aligned LTR text; I guess that all is reverse for RTL text.
Change log entries:
Not needed.
Code Review Checklist: