Improve versatility of System Test Framework, introduce ensure_speech_did_not_occur#13877
Merged
Conversation
feerrenrut
reviewed
Jul 11, 2022
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Rather than add a parameter, it might be better to add the corollary, I.E. ensure_not_spoken or similar. Mostly to make the tests easier to read, rather than having to invert the expectation.
What do you think? I'd also be ok with renaming wait_for_specific_speech if that helps.
wait_for_specific_speechensure_speech_did_not_occur
Member
Author
|
I've split the function into 2 now |
feerrenrut
reviewed
Jul 13, 2022
feerrenrut
reviewed
Jul 14, 2022
feerrenrut
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
While working on a separate PR, system tests were needed which changed the interval of checking speech, and to expect a failure.
This led to the contributor writing duplicate code to handle these cases, instead of improving the system test API.
That PR no longer requires this change, but the situation is generic enough to keep the API changes to make contributions easier in future.
Description of user facing changes
wait_for_specific_speechnow accepts a parameter to change the checking interval.A new function
ensure_speech_did_not_occurhas been introduced.Description of development approach
N/A
Testing strategy:
Tested when working on #13550
Known issues with pull request:
N/A
Change log entries:
N/A
Code Review Checklist: