Skip to content

Revert "Ignore hidden text in richEdit controls accessed with ITextDocument (PR #13618)"#13858

Merged
seanbudd merged 2 commits into
betafrom
revert-13618-beta
Jul 1, 2022
Merged

Revert "Ignore hidden text in richEdit controls accessed with ITextDocument (PR #13618)"#13858
seanbudd merged 2 commits into
betafrom
revert-13618-beta

Conversation

@seanbudd

@seanbudd seanbudd commented Jun 30, 2022

Copy link
Copy Markdown
Member

This reverts commit c591309.

Link to issue number:

Fixes #13826, reverts #13618

Summary of the issue:

#13618 causes a regression - #13826.
The PR needs to be reverted for 2022.2, and a new attempt at #13618 can be taken for 2022.3.

Description of user facing changes

#13618 is reverted: Hidden text will now be announced again in Wordpad and other richEdit controls.

Description of development approach

Note: another translation freeze may need to be announced.
The only translation changes is remove a line from changes.t2t.

Testing strategy:

Using a copy paste article from wikipedia.brh.txt opened in Baraha version 10.10.400 (64bit) and NVDA 2022.2beta2, #13826 was reproduced.

ctrl+downArrow and ctrl+upArrow lags between 0.5-1s on long paragraphs.

The PR build from this PR does not lag when navigating the same paragraphs.

Known issues with pull request:

None

Change log entries:

refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:

ctrl+downArrow and ctrl+upArrow lags between 0.5-1s on long paragraphs.

The PR build from this PR does not lag when navigating the same paragraphs.

@seanbudd seanbudd added this to the 2022.2 milestone Jun 30, 2022
@AppVeyorBot

This comment was marked as resolved.

@seanbudd

Copy link
Copy Markdown
Member Author

@narayan-b-raikar

Copy link
Copy Markdown

Thank you for responsing my Issue. The problem related to Paragraph navigation latency has been solved. Really I can easily navigate paragraphs without any problem. I hope that, It will be remained as same in next Stable update. Once again verry big thanks to your entire team. If you further want, I will try to submit aditional technical information related to this issue for next stable build.

Best regards.

@seanbudd seanbudd marked this pull request as ready for review July 1, 2022 00:58
@seanbudd seanbudd requested a review from a team as a code owner July 1, 2022 00:58
@seanbudd seanbudd requested review from feerrenrut and removed request for a team July 1, 2022 00:58

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we are confident this addresses the issue.

@seanbudd

seanbudd commented Jul 1, 2022

Copy link
Copy Markdown
Member Author

I reproduced #13826 with a copy paste article from wikipedia.brh.txt opened in Baraha version 10.10.400 (64bit) and NVDA 2022.2beta2.

ctrl+downArrow and ctrl+upArrow lags between 0.5-1s on long paragraphs.

The PR build from this PR does not lag when navigating the same paragraphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants