Update eSpeak to 1.52-dev commit dc153592#13849
Merged
Merged
Conversation
ENS_GROUP_ERRNO does not correctly capture errno without being treated as a flag
Contributor
|
espeak-ng/espeak-ng#1225 has been merged, so this PR is no longer blocked.
I added Mixe to eSpeak as part of a university project, partly because Mixe text is very difficult to work with under English eSpeak. Very happy to see that this work will be landing downstream soon! |
empty makefile diff
feerrenrut
reviewed
Jun 29, 2022
instead of when loading the scons script
feerrenrut
reviewed
Jun 29, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
Similar tests failed on #13851 at about the same time. Running the build again. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
empty makefile diff
feerrenrut
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #13295
Summary of the issue:
eSpeak is updated using the steps outlined in espeak.md.
Build issues fixed:
errnois raised. ourIntEnumimplementation ofespeak_ng_STATUSdoesn't correctly captureerrno. Usage ofIntFlagis required.This used to be handled by eSpeak implicitly through getting a mapping using the rules path.
This is no longer the case for some languages.
CLEANFILESfor certain language dictionary components. This can be mirrored byenv.Cleanoros.remove.Description of user facing changes
Added languages:
Description of development approach
New languages were added to the compile dictionary.
An annotated diff of Makefile.am can be checked to confirm the changes are implemented correctly into the build system: makefile.diff.
ctrl+f"_CHANGES" to find annotations.Testing strategy:
Fix 1 - Manual testing
Tested capturing
errno(whereerrno = 2) when runningscons source.This required a dictionary that would fail to compile (when reproducing Issue 2).
These are logged as follows:
General manual testing for Fix 2 and 3
Run
scons source, check output.Read text running from source
Fix 4
Tested reading Malay text with Malay language using 2022.1 to compare.
Build log shows build with "ms" as expcted.
this pr: https://ci.appveyor.com/project/NVAccess/nvda/builds/44017834?fullLog=true
Alpha: https://ci.appveyor.com/project/NVAccess/nvda/builds/44005620?fullLog=true
Known issues with pull request:
None
Change log entries:
Refer to PR diff
Code Review Checklist: