Change directory to package symbols#13790
Merged
Merged
Conversation
michaelDCurran
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up of #12540
Summary of the issue:
The server expects the symbols archive to be structured as
./*.ex_not./symbols/*.ex_.Due to changes in #12540, the symbols archive has been restructured to
./symbols/*.ex_.This is because 7zip structures the archive based on relative paths.
Description of how this pull request fixes the issue:
Reverts the 7zip symbol build to the old behaviour
Testing strategy:
Compare the output of this build's symbols.zip to the latest alpha
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: