Skip to content

Change input help documentation for move to first/last row scripts of fake table navigation in list views#13788

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:tableNavDoc
Jun 13, 2022
Merged

Change input help documentation for move to first/last row scripts of fake table navigation in list views#13788
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:tableNavDoc

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

Issue found while translating NVDA.

Link to issue number:

Follow-up of #13435.

Summary of the issue:

In fake table navigation in list views, horizontal movements only move the navigator object, whereas vertical movements move the navigator object but also the focus. This was not reflected in input help for the newly introduced commands to jump to first/last row.

Description of how this pull request fixes the issue:

  • Updated the two scripts documentation.
  • While at it, I have also converted remaining fake table navigation scripts to syntax with decorator.

Testing strategy:

Manual tests:

  • Checked input help
  • Checked that all fake table navigation still work in the detailed view of processes in the task manager.

Known issues with pull request:

None

Change log entries:

Not needed (fix in dev stage).

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

… fake table navigation in list views.

Also converted remaining fake table navigation scripts to syntax with decorator.
@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 10, 2022 12:29
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 10, 2022 12:29
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team June 10, 2022 12:29
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Additional note:
PR opened against beta branch since NVDA 2022.3 dev cycle has been initiated in the master (alpha) branch.
@feerrenrut, @seanbudd, could you please keep it in mind before releasing the first beta? Thanks!

@seanbudd seanbudd merged commit 424afaf into nvaccess:beta Jun 13, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jun 13, 2022
@seanbudd

Copy link
Copy Markdown
Member

Thanks @CyrilleB79

@seanbudd seanbudd modified the milestones: 2022.3, 2022.2 Jun 13, 2022
@CyrilleB79 CyrilleB79 deleted the tableNavDoc branch July 12, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants