Skip to content

Announce readonly state for Java text controls#13706

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
aphtech:jabReadonlyText
May 19, 2022
Merged

Announce readonly state for Java text controls#13706
seanbudd merged 2 commits into
nvaccess:masterfrom
aphtech:jabReadonlyText

Conversation

@mwhapples

@mwhapples mwhapples commented May 18, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #13692

Summary of the issue:

In a Java swing application NVDA does not announce a read only text control as being read only.

Description of how this pull request fixes the issue:

Java Access Bridge does not apply the editable state to read only controls. So when mapping JAB states to NVDA states check whether the control is a text control and whether it lacks the editable state, applying the read only state accordingly.

Testing strategy:

Manual testing.

Known issues with pull request:

None known.

Change log entries:

New features
Changes
Bug fixes
Fixes issue where read only state of text controls not spoken in applications using the Java Access Bridge.
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests None added but current tests pass.
    • System (end to end) tests None added, not sure how to add Java tests.
    • Manual testing Done.
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation No changes needed.
    • Developer / Technical Documentation No changes needed
    • Context sensitive help for GUI changes No changes needed.
  • UX of all users considered:
    • Speech Yes
    • Braille Yes
    • Low Visio Yesn
    • Different web N/A browsers
    • Localization in other languages / culture than English Yes

@mwhapples mwhapples requested a review from a team as a code owner May 18, 2022 13:38
@mwhapples mwhapples requested a review from seanbudd May 18, 2022 13:38
@seanbudd seanbudd changed the title Fix issue 13692 read only java text controls Announce readonly state for Java text controls May 19, 2022
@seanbudd seanbudd merged commit ac0aa9b into nvaccess:master May 19, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA does not announce the non-editable state of a non-editable JTextField (Java Access Bridge)

3 participants