Skip to content

Beta to master merge#13705

Merged
feerrenrut merged 30 commits into
masterfrom
beta
May 18, 2022
Merged

Beta to master merge#13705
feerrenrut merged 30 commits into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented May 18, 2022

Copy link
Copy Markdown
Member

Add fixes for 2022.1rc2 and updated translations

Note: must be a merge commit, not a squash merge

NVDA translation automation and others added 30 commits May 6, 2022 00:00
From translation svn revision: 67469

Authors:
Zahari Yurukov <zahari.yurukov@gmail.com>
Kostadin Kolev <k.kolev1985@gmail.com>

Stats:
1	0	user_docs/bg/changes.t2t
 1 file changed, 1 insertion(+)
From translation svn revision: 67469

Authors:
Ali Aslani <aslani.ali@gmail.com>
Mohammadreza Rashad <mohammadreza5712@gmail.com>

Stats:
4	6	source/locale/fa/LC_MESSAGES/nvda.po
3	1	user_docs/fa/changes.t2t
 2 files changed, 7 insertions(+), 7 deletions(-)
From translation svn revision: 67469

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
1	0	user_docs/fi/changes.t2t
 1 file changed, 1 insertion(+)
From translation svn revision: 67469

Authors:
Hrvoje Katic <hrvojekatic@gmail.com>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Milo Ivir <mivir@milotype.de>
Dejana Rakic <dejana.rakic.2@gmail.com>

Stats:
5	5	source/locale/hr/LC_MESSAGES/nvda.po
 1 file changed, 5 insertions(+), 5 deletions(-)
From translation svn revision: 67469

Authors:
Aron OcsvAri <oaron@nvda.hu>

Stats:
498	239	source/locale/hu/LC_MESSAGES/nvda.po
152	0	user_docs/hu/changes.t2t
 2 files changed, 650 insertions(+), 239 deletions(-)
From translation svn revision: 67469

Authors:
Simone Dal Maso <simone.dalmaso@gmail.com>
Alberto Buffolino <a.buffolino@gmail.com>

Stats:
5	4	source/locale/it/LC_MESSAGES/nvda.po
8	13	user_docs/it/changes.t2t
 2 files changed, 13 insertions(+), 17 deletions(-)
From translation svn revision: 67469

Authors:
Joseph Lee <joseph.lee22590@gmail.com>
Chang-Hwan Jang <462356@gmail.com>
Dong Hee Park <hi@aheu.org>
Stanley Chung <stanley@mail.com>

Stats:
13	13	source/locale/ko/LC_MESSAGES/nvda.po
4	2	user_docs/ko/changes.t2t
 2 files changed, 17 insertions(+), 15 deletions(-)
From translation svn revision: 67469

Authors:
zvonimir stanecic <9a5dsz@gozaltech.org>
Ertay Shashko <ertay@outlook.com>
Aleksandar <glupav@gmail.com>
Kiko Lazarev <kristijan.lazarev@gmail.com>

Stats:
3	3	source/locale/mk/LC_MESSAGES/nvda.po
 1 file changed, 3 insertions(+), 3 deletions(-)
From translation svn revision: 67469

Authors:
Grzegorz Zlotowicz <grzezlo@wp.pl>
Patryk Faliszewski <patric3031@wp.pl>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Dorota Krac <dorkakrac@yandex.com>
Piotr Rakowski <kontakt@piotrrakowski.net>
Hubert Meyer <hubmeyer1989@gmail.com>
Arkadiusz Swietnicki <nuno69a@gmail.com>

Stats:
331	331	source/locale/pl/LC_MESSAGES/nvda.po
 1 file changed, 331 insertions(+), 331 deletions(-)
From translation svn revision: 67469

Authors:
Ondrej Rosik <ondrej.rosik@gmail.com>
Peter Vagner <peter.v@datagate.sk>
Jan Kulik <jan.kulik.szsle@outlook.sk>

Stats:
3	1	user_docs/sk/changes.t2t
 1 file changed, 3 insertions(+), 1 deletion(-)
From translation svn revision: 67469

Authors:
Nikola Jovic <wwenikola123@gmail.com>
Janko Valencik <janko.valencik@alfanum.co.rs>
Zvonimir <9a5dsz@gozaltech.org>
Danijela Popovic <vlajna95@gmail.com>

Stats:
3	3	source/locale/sr/LC_MESSAGES/nvda.po
2	0	user_docs/sr/changes.t2t
 2 files changed, 5 insertions(+), 3 deletions(-)
From translation svn revision: 67469

Authors:
Dinakar T.D. <td.dinkar@gmail.com>

Stats:
8	6	source/locale/ta/LC_MESSAGES/nvda.po
2	2	user_docs/ta/userGuide.t2t
 2 files changed, 10 insertions(+), 8 deletions(-)
From translation svn revision: 67469

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
5	5	source/locale/tr/LC_MESSAGES/nvda.po
18	5	user_docs/tr/changes.t2t
 2 files changed, 23 insertions(+), 10 deletions(-)
From translation svn revision: 67469

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
18	18	user_docs/vi/userGuide.t2t
 1 file changed, 18 insertions(+), 18 deletions(-)
From translation svn revision: 67469

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
1	1	user_docs/zh_CN/userGuide.t2t
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 67469

Authors:
wangjanli@gmail.com
maro.zhang@gmail.com
Aaron Wu <waaron2000@gmail.com>
Victor Cai <surfer0627@gmail.com>
haach111000@gmail.com

Stats:
22	72	user_docs/zh_TW/changes.t2t
3	3	user_docs/zh_TW/userGuide.t2t
 2 files changed, 25 insertions(+), 75 deletions(-)
From translation svn revision: 67469
From translation svn revision: 67580

Authors:
Fatma Mehanna <fatma.mehanna@gmail.com>
Shaimaa Ibrahim <shamse1@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Omar Alojaimi <amrahmad1995@gmail.com>

Stats:
546	245	source/locale/ar/LC_MESSAGES/nvda.po
5	1	user_docs/ar/changes.t2t
 2 files changed, 551 insertions(+), 246 deletions(-)
From translation svn revision: 67580

Authors:
Ali Ustek <aliustek@gmail.com>
Patrick Galasso <Patrice.galasso@gmail.com>
Jwanro Mustafa <jwanroabdula@hotmail.com>
Kosrat D Ahmad <kosrat.d.ahmad@gmail.com>
silva.hm88@gmail.com

Stats:
86	89	source/locale/ckb/LC_MESSAGES/nvda.po
 1 file changed, 86 insertions(+), 89 deletions(-)
From translation svn revision: 67580

Authors:
Daniel K. Gartmann <kontakt@nvda.dk>
Nicolai Svendsen <chojiro1990@gmail.com>
bue@vester-andersen.dk

Stats:
2	2	source/locale/da/LC_MESSAGES/nvda.po
74	60	user_docs/da/changes.t2t
 2 files changed, 76 insertions(+), 62 deletions(-)
From translation svn revision: 67580

Authors:
Irene Nakas <irnakas@gmail.com>
Nikos Demetriou <nikosdemetriou@googlemail.com>
access@e-rhetor.com

Stats:
5	5	source/locale/el/LC_MESSAGES/nvda.po
 1 file changed, 5 insertions(+), 5 deletions(-)
From translation svn revision: 67580

Authors:
Bram Duvigneau <bram@bramd.nl>
Bart Simons <bart@bartsimons.be>
A Campen <a.campen@wxs.nl>
Leonard de Ruijter <alderuijter@gmail.com>

Stats:
502	233	source/locale/nl/LC_MESSAGES/nvda.po
 1 file changed, 502 insertions(+), 233 deletions(-)
From translation svn revision: 67580

Authors:
Diogo Costa <diogojoca@gmail.com>
Rui Batista <ruiandrebatista@gmail.com>
Rui Fontes <rui.fontes@tiflotecnia.com>
Ângelo Abrantes <ampa4374@gmail.com>

Stats:
1	0	user_docs/pt_PT/changes.t2t
 1 file changed, 1 insertion(+)
From translation svn revision: 67580

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
4	4	source/locale/vi/LC_MESSAGES/nvda.po
1	1	user_docs/vi/changes.t2t
82	83	user_docs/vi/userGuide.t2t
 3 files changed, 87 insertions(+), 88 deletions(-)
From translation svn revision: 67580

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
2	2	source/locale/zh_CN/LC_MESSAGES/nvda.po
 1 file changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 67580

Authors:
Eric Yip <ericycy@gmail.com>

Stats:
467	235	source/locale/zh_HK/LC_MESSAGES/nvda.po
 1 file changed, 467 insertions(+), 235 deletions(-)
From translation svn revision: 67580

Authors:
wangjanli@gmail.com
maro.zhang@gmail.com
Aaron Wu <waaron2000@gmail.com>
Victor Cai <surfer0627@gmail.com>
haach111000@gmail.com

Stats:
38	51	source/locale/zh_TW/LC_MESSAGES/nvda.po
1845	1845	source/locale/zh_TW/characterDescriptions.dic
46	46	user_docs/zh_TW/userGuide.t2t
 3 files changed, 1929 insertions(+), 1942 deletions(-)
From translation svn revision: 67580
Closes part of #13679

Summary of the issue:
It appears that when resetting a config, the seika notetaker driver can be terminated before it has been initialized.

Description of how this pull request fixes the issue:
Only terminate the notetaker driver if it has been initialized.

Known issues with pull request:
Another issue is highlighted in #13679. While terminating/initializing during a config change, the braille.handler is attempted to be used when handling events on NVDA objects.
This is a more complex problem and needs a braille device to reproduce and test.
Fixes #13694

Summary of the issue:
NVDA start up is slow.
Speech is announced during start up to warn the user that start up is slow.
If using SAPI5 and audioducking is enabled, SAPI5 will try to duck the audio using wx callbacks
The wxWidgets App has not beeing initialized, so the callback fails and NVDA crashes.
Description of how this pull request fixes the issue:
Throw a known exception if NVDA is not ready when callLater is called.
If this exception occurs when audio ducking, force audio ducking to unduck immediately instead of delay

Testing strategy:
Manual testing:

Using NVDA 2022.1rc1 with audio ducking enabled and SAPI5.

emulate a slow start up and reproduce the crash.
Using a try build from this PR with audio ducking enabled and SAPI5.

emulate a slow start up.
Note that the warning message that announces that NVDA start up is slow doesn't duck audio
Note that NVDA starts successfully
Confirm that audio ducking works as expected once NVDA has started
Note the following log
WARNING - mathPres.initialize (12:46:35.192) - MainThread (6344):
MathPlayer 4 not available
DEBUGWARNING - core.main (12:46:40.207) - MainThread (6344):
Slow starting core (6.88 sec)
IO - speech.speech.speak (12:46:40.207) - MainThread (6344):
Speaking [LangChangeCommand ('en_US'), 'Loading NVDA. Please wait...']
DEBUGWARNING - characterProcessing._getSpeechSymbolsForLocale (12:46:40.208) - MainThread (6344):
No CLDR data for locale en_US
DEBUGWARNING - synthDrivers.sapi5.SynthDriver.speak (12:46:40.344) - MainThread (6344):
Unsupported speech command: LangChangeCommand ('en_US')
DEBUGWARNING - audioDucking._unensureDucked (12:46:40.349) - MainThread (6344):
wx App not initialized, cannot delay audio un-duck
INFO - core.main (12:46:40.349) - MainThread (6344):
Using wx version 4.1.1 msw (phoenix) wxWidgets 3.1.5 with six version 1.16.0
@seanbudd seanbudd requested a review from a team as a code owner May 18, 2022 04:31
@feerrenrut feerrenrut merged commit 6cffa4d into master May 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants