Add a script to cycle through language switching modes.#13680
Merged
Conversation
See test results for failed build of commit b455bd0f30 |
seanbudd
reviewed
May 11, 2022
Member
|
Thanks @CyrilleB79 - LGTM otherwise |
seanbudd
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10253
Summary of the issue:
A gesture is missing to control automatic language switching and automatic dialect switching options.
Description of how this pull request fixes the issue:
Add an unassigned script that cycles through the 3 following automatic language and dialect switching modes:
• Language and dialect switching on
Note that the 4th possible state (language switching off and dialect switching on) does not make sense.
Testing strategy:
Note: The number 70 is said to be "soixante-dix" in French from France and "septante" in French from Belgium. Hence the easy test to distinguish one dialect from another.
Known issues with pull request:
In #10253, the alternative solution to include this toggle in the synth setting ring was suggested by @JulienCochuyt.
Since the synth settings ring already contains many parameters, I have not retained this solution. Should #7747 be implemented, we can re-discuss it at that time.
Also a dedicated gesture is faster than the ring and thus would fulfill the expectations of #10253 (comment).
Change log entries:
New features
An unassigned script to cycle through language and dialect switching modes have been added. (#10253)Code Review Checklist: