Skip to content

Add a script to cycle through language switching modes.#13680

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
CyrilleB79:autoLangSwitchGesture
May 11, 2022
Merged

Add a script to cycle through language switching modes.#13680
seanbudd merged 4 commits into
nvaccess:masterfrom
CyrilleB79:autoLangSwitchGesture

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #10253

Summary of the issue:

A gesture is missing to control automatic language switching and automatic dialect switching options.

Description of how this pull request fixes the issue:

Add an unassigned script that cycles through the 3 following automatic language and dialect switching modes:

  • Language and dialect switching off
  • Language switching on, dialect switching off
    • Language and dialect switching on

Note that the 4th possible state (language switching off and dialect switching on) does not make sense.

Testing strategy:

  • Called the script many times and checked the result in the Speech Settings panel after each call
  • Tested with eSpeak in French (Franche) the text on this test page: ExamplePageWithLangTag.html.txt
    Note: The number 70 is said to be "soixante-dix" in French from France and "septante" in French from Belgium. Hence the easy test to distinguish one dialect from another.

Known issues with pull request:

In #10253, the alternative solution to include this toggle in the synth setting ring was suggested by @JulienCochuyt.
Since the synth settings ring already contains many parameters, I have not retained this solution. Should #7747 be implemented, we can re-discuss it at that time.
Also a dedicated gesture is faster than the ring and thus would fulfill the expectations of #10253 (comment).

Change log entries:

New features
An unassigned script to cycle through language and dialect switching modes have been added. (#10253)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit b455bd0f30

@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 11, 2022 05:24
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 11, 2022 05:24
@CyrilleB79 CyrilleB79 requested a review from michaelDCurran May 11, 2022 05:24
Comment thread source/globalCommands.py Outdated
@seanbudd

Copy link
Copy Markdown
Member

Thanks @CyrilleB79 - LGTM otherwise

@seanbudd seanbudd merged commit 64301ba into nvaccess:master May 11, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 11, 2022
@CyrilleB79 CyrilleB79 deleted the autoLangSwitchGesture branch May 11, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a script to toggle language detection

4 participants