Skip to content

Add helperLocalBindingHandle to NVDAObject appModule devInfo#13662

Merged
seanbudd merged 2 commits into
masterfrom
extendAppModuleDevInfo
May 4, 2022
Merged

Add helperLocalBindingHandle to NVDAObject appModule devInfo#13662
seanbudd merged 2 commits into
masterfrom
extendAppModuleDevInfo

Conversation

@seanbudd

@seanbudd seanbudd commented May 4, 2022

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

When developing #13657, logging NVDAObject.appModule.helperLocalBindingHandle was helpful.
NVDAObject._get_devInfo is considered too complex, and should aim to be shortened.

Description of how this pull request fixes the issue:

Moves the appModule devInfo logging out of NVDAObject._get_devInfo into AppModule.get_devInfo.
Adds appModule.helperLocalBindingHandle to the log info for an NVDAObject.

Testing strategy:

Test with NVDA+F1 on various NVDAObjects.

Known issues with pull request:

None

Change log entries:

None needed

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested a review from a team as a code owner May 4, 2022 01:21
@seanbudd seanbudd requested a review from feerrenrut May 4, 2022 01:21
@AppVeyorBot

This comment was marked as off-topic.

@seanbudd seanbudd merged commit 929d565 into master May 4, 2022
@seanbudd seanbudd deleted the extendAppModuleDevInfo branch May 4, 2022 04:37
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants