Skip to content

Fix say-all with oneCore synth#13652

Merged
feerrenrut merged 1 commit into
betafrom
fixOcSpeechSayAll
Apr 29, 2022
Merged

Fix say-all with oneCore synth#13652
feerrenrut merged 1 commit into
betafrom
fixOcSpeechSayAll

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #13651

Summary of the issue:

Starting say-all with synth set to onecore fails with an error.

A logic error in the change: #13634
Causes the "markerStr" to be constructed incorectly. The | character expected to separate entries was missing.

Example string: 20:1437521:18864375
Should be instead: 20:14375|21:18864375

Description of how this pull request fixes the issue:

Fix the logic error, every entry after the first should start with a | character.

Testing strategy:

Tested say all in edge with synth set to oneCore.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

Issue introduced with PR
#13634
@feerrenrut feerrenrut requested a review from a team as a code owner April 29, 2022 07:13
@feerrenrut feerrenrut requested review from seanbudd and removed request for a team April 29, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants