Fix say-all with oneCore synth#13652
Merged
Merged
Conversation
Issue introduced with PR #13634
seanbudd
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13651
Summary of the issue:
Starting say-all with synth set to onecore fails with an error.
A logic error in the change: #13634
Causes the "markerStr" to be constructed incorectly. The
|character expected to separate entries was missing.Example string:
20:1437521:18864375Should be instead:
20:14375|21:18864375Description of how this pull request fixes the issue:
Fix the logic error, every entry after the first should start with a
|character.Testing strategy:
Tested say all in edge with synth set to oneCore.
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: