Skip to content

Fix HTML characters in mozilla rich edit causing error#13644

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
aphtech:mozillaRichEditHtmlCharacters
May 2, 2022
Merged

Fix HTML characters in mozilla rich edit causing error#13644
seanbudd merged 3 commits into
nvaccess:masterfrom
aphtech:mozillaRichEditHtmlCharacters

Conversation

@mwhapples

@mwhapples mwhapples commented Apr 26, 2022 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #12542

Summary of the issue:

In mozilla applications when pasting certain HTML into rich edit controls it can lead to errors when navigating through the text. One such example is in the thunderbird compose message edit area.

Description of how this pull request fixes the issue:

The function _getEmbedded in ia2TextMozilla.py returns Optional, however the return value is never checked to be not None and this assumption leads to errors later on when the value is used. This pull request adds a check for None being returned from _getEmbedded and skips it if None is found.

Testing strategy:

Manually tested.

Known issues with pull request:

None known.

Change log entries:

New features
Changes
Bug fixes No longer give errors when navigating certain text in Mozilla rich edit controls.
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests Unsure how to add tests for this.
    • System (end to end) tests Unsure how to add tests for this.
    • Manual testing Done
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@mwhapples mwhapples requested a review from a team as a code owner April 26, 2022 14:52
@mwhapples mwhapples requested a review from seanbudd April 26, 2022 14:52
@mwhapples mwhapples mentioned this pull request Apr 26, 2022
Closed
@AppVeyorBot

AppVeyorBot commented Apr 26, 2022

Copy link
Copy Markdown

See test results for failed build of commit 2e3fa39e95

@seanbudd

seanbudd commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I'm unable to push changes to the aphtech fork. I believe you need to invite us as collaborators to the fork to be able to push changes. This differs from user forks, which we can push to by default.

The changelog entry I was trying to add is as follows:

- Fix braille output when navigating certain text in Mozilla rich edit controls, such as drafting a message in Thunderbird. (#12542)

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 27, 2022
@mwhapples

mwhapples commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

I thought I had set the pull request to want to merge into nvaccess/nvda master branch. I will need to check if I have done anything wrong when creating the pull request and how to change my work flow./

@seanbudd

seanbudd commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@mwhapples - you'll need to add NV Access developers as contributors to the aphtech/nvda repository. So that we can push changes to that repository.

@mwhapples

mwhapples commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

@seanbudd I have given you write access to aphtech/nvda, any other NVDA developer I should grant access, or do you have a team I can add?

@seanbudd

seanbudd commented May 2, 2022

Copy link
Copy Markdown
Member

Thanks - you might be able to invite @nvaccess/developers otherwise, @feerrenrut and @michaelDCurran getting an invite should be fine for now.

@AppVeyorBot

AppVeyorBot commented May 2, 2022

Copy link
Copy Markdown
  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 8b7b70f61e

@seanbudd seanbudd changed the title Fix issue#12542 HTML characters in mozilla rich edit can cause error Fix HTML characters in mozilla rich edit causing error May 2, 2022
@seanbudd seanbudd merged commit 5bab7db into nvaccess:master May 2, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2022.2

Development

Successfully merging this pull request may close these issues.

Thunderbird: certain characters with some HTML codes break braille output in the compose window

4 participants

@mwhapples @AppVeyorBot @seanbudd @nvaccessAuto