Skip to content

Update controllerClient information#13639

Merged
feerrenrut merged 3 commits into
masterfrom
updateControllerClientDocs
May 19, 2022
Merged

Update controllerClient information#13639
feerrenrut merged 3 commits into
masterfrom
updateControllerClientDocs

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

None, discussion on mailing list:
https://groups.io/g/nvda-devel/message/46179

Summary of the issue:

NVDA controller client information is outdated, and could be clarified.

Description of how this pull request fixes the issue:

Clarify information, provide updated links.

Testing strategy:

None

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut marked this pull request as ready for review April 26, 2022 09:59
@feerrenrut feerrenrut requested a review from a team as a code owner April 26, 2022 09:59
@feerrenrut feerrenrut requested a review from seanbudd April 26, 2022 09:59
Comment thread extras/controllerClient/readme.md Outdated
Comment thread extras/controllerClient/readme.md Outdated
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 27, 2022

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

Comment thread extras/controllerClient/readme.md Outdated
@seanbudd

Copy link
Copy Markdown
Member

apologies for the late review

Co-authored-by: Sean Budd <sean@nvaccess.org>
@feerrenrut feerrenrut merged commit 1d404b3 into master May 19, 2022
@feerrenrut feerrenrut deleted the updateControllerClientDocs branch May 19, 2022 10:10
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants