Skip to content

Fix NVDA interaction with Java progress bars (#13594)#13595

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
thgcode:fix/java-progress-bars
Apr 21, 2022
Merged

Fix NVDA interaction with Java progress bars (#13594)#13595
seanbudd merged 4 commits into
nvaccess:masterfrom
thgcode:fix/java-progress-bars

Conversation

@thgcode

@thgcode thgcode commented Apr 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #13594

Summary of the issue:

Currently, NVDA does not beep on Java progress bars. This happens because the progress bar is not added to the overlay classes when Java sends the "progress bar" role to NVDA.

Description of how this pull request fixes the issue:

This pull request adds the missing ProgressBar class when it detects the "progress bar" role.

Testing strategy:

Tested by running both with Intellij and this gist https://gist.github.com/brunosantanati/3c9e5778ba591b6218b6a210da1fc17f

Known issues with pull request:

None at the time.

Change log entries:

New features
Changes
Bug fixes

NVDA can now beep or speak on Java progress bars (#13594)

For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot

AppVeyorBot commented Apr 8, 2022

Copy link
Copy Markdown

See test results for failed build of commit 57c45fafcf

@thgcode

thgcode commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

While the system tests are failing, I think the change I made does not affect them, since the failing test is a Chrome HTML one.

@thgcode thgcode marked this pull request as ready for review April 8, 2022 22:40
@thgcode thgcode requested a review from a team as a code owner April 8, 2022 22:40
@thgcode thgcode requested a review from seanbudd April 8, 2022 22:40
@CyrilleB79

CyrilleB79 commented Apr 9, 2022

Copy link
Copy Markdown
Contributor

There has been failing tests with Chrome recently. A fix has been merged by NVAccess in the master branch. So if your branch is not up-to-date with latest master, you can merge master to your branch and check if the issue is resolved.

If not (or if you are already up-to-date with master), just wait for NVAccess to fix other issues with Chrome test. You do not need to do anything else.

@thgcode

thgcode commented Apr 9, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the reply! I'll wait then, it's already on latest master.

@AppVeyorBot

AppVeyorBot commented Apr 11, 2022

Copy link
Copy Markdown

See test results for failed build of commit 22f274400c

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 19, 2022
@AppVeyorBot

AppVeyorBot commented Apr 20, 2022

Copy link
Copy Markdown

See test results for failed build of commit 6336569ec6

@AppVeyorBot

AppVeyorBot commented Apr 20, 2022

Copy link
Copy Markdown

See test results for failed build of commit 26b53818f3

@AppVeyorBot

AppVeyorBot commented Apr 20, 2022

Copy link
Copy Markdown

See test results for failed build of commit 5b0d4079ee

@seanbudd seanbudd merged commit 8cbdb79 into nvaccess:master Apr 21, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2022.2

Development

Successfully merging this pull request may close these issues.

NVDA doesn't beep on Java Progress bars

5 participants

@thgcode @AppVeyorBot @CyrilleB79 @seanbudd @nvaccessAuto