[Cherry-pick to beta] Advanced settings panel: restore accelerator key#13590
Merged
Conversation
…13437). (nvaccess#13563) Fix-up of nvaccess#13437. Summary of the issue: With nvaccess#13437, the option "Use UI Automation to access Microsoft Word document controls" in Advanced settings panel has become a combo-box; it was a checkbox before. In the same time, the accelerator key (mapped to W) has been removed for this option: "&" removed from the label. When testing Word with and without UIA, it was handy to focus the Advanced panel, check the first checkbox and press alt+W to jump directly to this option. Now tabbing between the options is required. Description of how this pull request fixes the issue: Just add the "&" in the label to restore the accelerator key for this option.
See test results for failed build of commit 88842299fb |
Member
|
Thanks @CyrilleB79 - I was about to ask you to open this PR |
seanbudd
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: PR targetting beta before translation freeze extension. Please consider it before the new translation freeze / the beta4. Thanks.
Cc @seanbudd, @feerrenrut, @michaelDCurran
Link to issue number:
PR #13563.
Summary of the issue:
PR #13563 restores an accelerator key that has been removed by #13437 during NVDA 2022.1 release cycle.
Unfortunately, PR #13563 has been opened after translation freeze and thus could not integrate 2022.1.
However in #13563, I have written:
According to this thread, an extension translation freeze is in preparation with new translatable strings.
Thus this allow to integrate this fix for 2022.1 considering that the accelerator key was removed during 2022.1 dev cycle.
Description of how this pull request fixes the issue:
Cherry-pick the commit corresponding to #13563, i.e. c446688.
Testing strategy:
Manual check of the access key in the advanced settings panel.
Known issues with pull request:
I have no experience of cherry picking. Could it have a bad side effect when merging back beta to master?
Change log entries:
New featuresNone
Code Review Checklist: