Skip to content

Adobe Acrobat: report type and state of form fields in non-interactive PDFs#13546

Merged
michaelDCurran merged 2 commits into
masterfrom
i13285
Mar 28, 2022
Merged

Adobe Acrobat: report type and state of form fields in non-interactive PDFs#13546
michaelDCurran merged 2 commits into
masterfrom
i13285

Conversation

@michaelDCurran

@michaelDCurran michaelDCurran commented Mar 28, 2022

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #13285

Summary of the issue:

Non-interactive PDFs can contain form fields such as checkboxes and radio buttons. however, NVDA does not report any meaningful type or state for them at all.
This is due to the fact that NVDA specifically maps the PDF stdName (tag) of 'Form' to NVDA's Form role. Thereby completely overriding any more detailed MSAA role Adobe has provided.
This was most likely due to a mis-understanding of the PDF spec. The <form> tag means form field, not form.

Description of how this pull request fixes the issue:

Remove the mapping of Form stdName to NVDA's Form role. so that NVDA will fall back to using the MSAA role / states provided by Adobe Acrobat.

Testing strategy:

Opened the test file provided in #13285 Adobe Reader, and arrowed down to the checkbox. Ensured that NVDA reported the checkbox was a checkbox and that it was checked.

Known issues with pull request:

NVDA does however also report unavailable and readonly states on this checkbox. But I think this is because the checkbox is non-interactive, I.e. cannot be actually changed. If this is found to be problematic, it should be addressed in further issues / prs. Right now we are reporting the information that Adobe provides us.

Change log entries:

New features
Changes
Bug fixes

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

…ole. This was a mis-understanding of the PDF spec. Form is really form field, and Acrobat already provides more detailed MSAA roles and states for these fields.
@michaelDCurran michaelDCurran requested a review from a team as a code owner March 28, 2022 01:14
@michaelDCurran michaelDCurran requested a review from seanbudd March 28, 2022 01:14
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 25c7171e73

@michaelDCurran michaelDCurran merged commit f08d914 into master Mar 28, 2022
@michaelDCurran michaelDCurran deleted the i13285 branch March 28, 2022 03:56
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA not able to read the checkbox/radio button status in case of static non interactive(print form) pdf

4 participants