Adobe Acrobat: report type and state of form fields in non-interactive PDFs#13546
Merged
Conversation
…ole. This was a mis-understanding of the PDF spec. Form is really form field, and Acrobat already provides more detailed MSAA roles and states for these fields.
seanbudd
approved these changes
Mar 28, 2022
See test results for failed build of commit 25c7171e73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13285
Summary of the issue:
Non-interactive PDFs can contain form fields such as checkboxes and radio buttons. however, NVDA does not report any meaningful type or state for them at all.
This is due to the fact that NVDA specifically maps the PDF stdName (tag) of 'Form' to NVDA's Form role. Thereby completely overriding any more detailed MSAA role Adobe has provided.
This was most likely due to a mis-understanding of the PDF spec. The
<form>tag means form field, not form.Description of how this pull request fixes the issue:
Remove the mapping of Form stdName to NVDA's Form role. so that NVDA will fall back to using the MSAA role / states provided by Adobe Acrobat.
Testing strategy:
Opened the test file provided in #13285 Adobe Reader, and arrowed down to the checkbox. Ensured that NVDA reported the checkbox was a checkbox and that it was checked.
Known issues with pull request:
NVDA does however also report unavailable and readonly states on this checkbox. But I think this is because the checkbox is non-interactive, I.e. cannot be actually changed. If this is found to be problematic, it should be addressed in further issues / prs. Right now we are reporting the information that Adobe provides us.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: