Skip to content

Adding jump to first/last row/column commands in list views and Tree Views.#13470

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
mltony:table_last_fake
Mar 27, 2022
Merged

Adding jump to first/last row/column commands in list views and Tree Views.#13470
michaelDCurran merged 1 commit into
nvaccess:masterfrom
mltony:table_last_fake

Conversation

@mltony

@mltony mltony commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

#957

Summary of the issue:

Introduce commands to jump to first/last row/column in current table.

Description of how this pull request fixes the issue:

This PR introduces Control+Alt+Home/End/PageUp/PageDown commands in ListViews and TreeViews - implemented in class RowWithFakeNavigation.

Testing strategy:

  • Tested in NVDA Punctuation/Symbol pronounciation list view.
  • Tested in Thunderbird messages ListView and TreeView.

Known issues with pull request:

In Thunderbird Control+Alt+PageUp command doesn't work - this is due to the fact that focus.parent.firstChild is an object with different role. This appears to be a problem on Thunderbird side. It also affects other table navigation commands, e.g. Control+Alt+UpArrow.

Change log entries:

Please use changelog entry from #13435.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@mltony mltony requested a review from a team as a code owner March 13, 2022 17:53
@mltony mltony requested a review from seanbudd March 13, 2022 17:53
@cary-rowen

This comment was marked as off-topic.

@feerrenrut feerrenrut added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 18, 2022
@michaelDCurran michaelDCurran merged commit 1f05a49 into nvaccess:master Mar 27, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants