Skip to content

Correcting typos in appveyor/scripts/installNVDA.ps1#13466

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
XLTechie:appveyorNVDAInstallScriptTypoFix
Mar 13, 2022
Merged

Correcting typos in appveyor/scripts/installNVDA.ps1#13466
michaelDCurran merged 2 commits into
nvaccess:masterfrom
XLTechie:appveyorNVDAInstallScriptTypoFix

Conversation

@XLTechie

@XLTechie XLTechie commented Mar 12, 2022

Copy link
Copy Markdown
Collaborator

Link to issue number:

Summary of the issue:

While working with installNVDA.ps1, I noticed that the variable:

$installerLogFilePathToUpload

was being spelled:

$installlerLogFilePathToUpload

Since I was fixing that, I also corrected a typo in a comment.

Description of how this pull request fixes the issue:

Corrected the spelling of the variable name in all three uses, by removing the first "l".

Testing strategy:

None - my build environment is broken currently, but this should have no effect on anything.
The try build should confirm that it works.

Known issues with pull request:

Change log entries:

None needed.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@XLTechie XLTechie marked this pull request as ready for review March 12, 2022 02:12
@XLTechie XLTechie requested a review from a team as a code owner March 12, 2022 02:12
@XLTechie XLTechie requested a review from seanbudd March 12, 2022 02:12
@XLTechie

Copy link
Copy Markdown
Collaborator Author

CC @seanbudd since I think you did the restructuring on the Appveyor scripts.

@michaelDCurran michaelDCurran merged commit 19800ef into nvaccess:master Mar 13, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 13, 2022
@XLTechie XLTechie deleted the appveyorNVDAInstallScriptTypoFix branch March 15, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants