Skip to content

Fix duplicate keys#13421

Merged
feerrenrut merged 1 commit into
masterfrom
removeDupsIAMappings
Mar 4, 2022
Merged

Fix duplicate keys#13421
feerrenrut merged 1 commit into
masterfrom
removeDupsIAMappings

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

While this doesn't cause an issue currently, it could be confusing.
State/Role mappings of IA to NVDA enums containined duplicates:

  • IAccessibleRolesToNVDARoles
  • IAccessibleStatesToNVDAStates

Description of how this pull request fixes the issue:

Remove the duplicates.

Testing strategy:

System tests
Alpha testsing

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

State/Role mappings of IA to NVDA enums containined duplicates:
- IAccessibleRolesToNVDARoles
- IAccessibleStatesToNVDAStates
@feerrenrut feerrenrut requested a review from a team as a code owner March 3, 2022 09:42
@feerrenrut feerrenrut requested a review from seanbudd March 3, 2022 09:42
@feerrenrut

Copy link
Copy Markdown
Contributor Author

Other entry for oleacc.ROLE_SYSTEM_OUTLINEBUTTON: controlTypes.Role.TREEVIEWBUTTON,
at line 132

Other entry for oleacc.STATE_SYSTEM_TRAVERSED: controlTypes.State.VISITED
at line 208

@feerrenrut feerrenrut merged commit c1e475a into master Mar 4, 2022
@feerrenrut feerrenrut deleted the removeDupsIAMappings branch March 4, 2022 03:19
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants