Fix table navigation in browse mode in MS Word for PR #13345#13396
Conversation
… class UIABrowseModeDocumentTextInfo comparable
1d72cab to
ee37c2b
Compare
|
has this been tested with browse mode and focus mode? |
|
@seanbudd, I cannot call parent hash function here - I spent quite some time debugging this. Here is the reason. So it uses the object as key in a dictionary during a call to BTW on a tengential note, there seems to be a fundamental problems with |
|
Does this handle also i.e. rows of different number of cells? See for example isue #2683. |
|
This only forwards eq function for certain instances of TextInfo, it doesn't directly change any table-related behavior. |
Link to issue number:
Issue with navigating over merged cells in MS Word while in browse mode discussed in PR #13345.
Summary of the issue:
PR #13345 fixes navigating over merged cells in tables by caching the last column/row. Testing showed that it doesn't work in MS Word while in browse mode (focus mode works fine). This was tracked down to class UIABrowseModeDocumentTextInfo not implementing eq method.
Description of how this pull request fixes the issue:
Fixing that by implementing eq and hash functions in parent class RootProxyTextInfo.
Testing strategy:
Tested in MS Word. Tried with both checked and unchecked value of "Always use UI Automation to access Microsoft Word document controls when available".
Known issues with pull request:
N/A
Change log entries:
Doesn't deserve a separate entry, should be merged with #13345.
Code Review Checklist: