Rewrote and expanded the Browse mode: Use Screen Layout section in the user guide to correct missing information#13373
Merged
Conversation
Collaborator
Author
See test results for failed build of commit 52bee3df28 |
This comment was marked as resolved.
This comment was marked as resolved.
lukaszgo1
reviewed
Feb 22, 2022
…the user guide. * The primary focus was to add a note explaining that the option is inapplicable for Microsoft Office apps. (Per comment on #13354) * Removed extraneous words ("content in", first sentence), and fixed plural-singular errors. * Generally expanded the section to better explain the option, and give an example.
Contributor
|
Actually, it would be nice to review the User guide for all the options of Browse mode settings.
Or better, it would be nice to split the options of this window in two groups, one for browse mode (including Word and Outlook) and one only for virtual buffers in browsers. |
Qchristensen
approved these changes
Mar 4, 2022
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Thanks @XLTechie for the PR and @CyrilleB79 for your insight as well! The idea of rewriting the Browse mode section of the User Guide came up recently and I have intentions of going through it in more detail.
In the meantime, great work on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Addresses a concern raised in #13354
Summary of the issue:
In this comment, @CyrilleB79 pointed out that the user guide does not indicate that screen layout is always used in Outlook, irrespective of the "Use screen layout" setting.
It seems reasonable for the user to assume, since it isn't otherwise indicated, that turning off screen layout will be effective anywhere browse mode is used, when in fact this is not the case.
Description of how this pull request fixes the issue:
I added a note to the section in the user guide, explaining that this option is not applicable to Microsoft Office applications.
While looking at the section, I thought that it didn't really explain well the difference between screen layout and not screen layout, and used terms like "fields" in a way that most users might not associate with the elements changed by the option.
Testing strategy:
N/A
Known issues with pull request:
I'm not convinced that the result is the best way to present screen layout or the option, but I think it is preferable to what was there, at least until something better comes along.
Change log entries:
User Guide: Improved the explanation of the browse mode "Use screen layout" option, now including that it doesn't apply to Outlook, Word, etc.
Code Review Checklist: