Scons: revert providing the number of logical processors as the number of maximum concurrent jobs to speed up builds by default#13371
Merged
Conversation
…r of maximum concurrent jobs to speed up builds by default
This comment was marked as off-topic.
This comment was marked as off-topic.
seanbudd
approved these changes
Mar 3, 2022
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @LeonarddeR , we are going with this approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Reverts #13226
Summary of the issue:
While building NVDA with multiple jobs leads to faster build times, it also leads to scrambled output which can be quite annoying when debugging.
Description of how this pull request fixes the issue:
Disable multiple jobs by default but warn users to run with -jX to get a faster build if applicable.
Testing strategy:
Tested specifying several numbers of build jobs on the command line
Known issues with pull request:
None known
Change log entries:
included in pr
Code Review Checklist: