Skip to content

Utilise readonly state when determining browse mode for mail in Windows 11#13292

Merged
seanbudd merged 3 commits into
masterfrom
fix-13050
Jan 31, 2022
Merged

Utilise readonly state when determining browse mode for mail in Windows 11#13292
seanbudd merged 3 commits into
masterfrom
fix-13050

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Link to issue number:

Closes #13050

Summary of the issue:

To determine if we should use browse mode or focus mode for Windows 10 mail, NVDA
would check if the email headers are set, and not draft headers.
In Windows 11 mail, email headers can be scrolled out of focus.
When returning focus to an email, after headers have been scrolled out of focus, NVDA incorrectly assumes we are in a draft email.

Description of how this pull request fixes the issue:

Windows 11 correctly sets the readonly state for emails.
This PR uses the readonly state to enable browse mode for mail in Windows 11

Testing strategy:

Steps to reproduce:

  1. Find a long email using Windows Mail, on Windows 11
  2. Go down many lines (if sighted, until headers are scrolled out of view)
  3. Press a command to open a dialog in NVDA, EG (NVDA+Ctrl+S) for the synthesizer dialog,
  4. Press escape to close the synthesizer dialog
  5. Try arrowing around the email.
    • Before this PR, this would cause the same line in the email to be repeatedly spoken
    • After this PR, navigation around the email works as expected

Known issues with pull request:

None

Change log entries:

Bug fixes

- Fixes issue with Windows 11 Mail. After switching focus between apps, while reading a long email, NVDA would get stuck on a line of the email. (#13050)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd requested a review from a team as a code owner January 31, 2022 05:52

@michaelDCurran michaelDCurran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seanbudd seanbudd merged commit 6dae6ab into master Jan 31, 2022
@seanbudd seanbudd deleted the fix-13050 branch January 31, 2022 06:58
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA gets stuck on line in Windows Mail if you open an NVDA dialog

3 participants