Add a shortcut key to toggle braille viewer.#13265
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Qchristensen
approved these changes
Jan 27, 2022
Qchristensen
left a comment
Member
There was a problem hiding this comment.
User Guide change is consistent with other similar comments in other places in the User Guide, good work!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5071a78 to
4725bcc
Compare
See test results for failed build of commit 901f0229c0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13258
Summary of the issue:
In #13258, it was asked to have a gesture to toggle braille viewer activation/deactivation as it already exists for speech viewer. It is not very clear why there was a gesture to toggle speech viewer and not for braille viewer.
Description of how this pull request fixes the issue:
Testing strategy:
Manual testing:
Note: System test is failing on Chrome test, but I think it is unrelated and other PRs also fail the Chrome test.
Known issues with pull request:
None
Change log entries:
New features
Added a command to toggle the braille viewer; there is no default associated gesture. (#13258)Code Review Checklist: