Skip to content

Add a shortcut key to toggle braille viewer.#13265

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:toggleBrailleViewer
Jan 28, 2022
Merged

Add a shortcut key to toggle braille viewer.#13265
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:toggleBrailleViewer

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #13258

Summary of the issue:

In #13258, it was asked to have a gesture to toggle braille viewer activation/deactivation as it already exists for speech viewer. It is not very clear why there was a gesture to toggle speech viewer and not for braille viewer.

Description of how this pull request fixes the issue:

  • Created a script with unassigned gesture in the global commands to toggle the braille viewer.
  • Updated the user doc

Testing strategy:

Manual testing:

  • Associated a gesture to the new script in the input gesture window
  • Checked that this gesture allows to enable/disable the braille viewer
  • Checked that the "Braille viewer" item in NVDA -> Tools menu is checked / not checked accordingly
  • Tried to open braille viewer with the gesture and close it via the menu and vice versa.

Note: System test is failing on Chrome test, but I think it is unrelated and other PRs also fail the Chrome test.

Known issues with pull request:

None

Change log entries:

New features
Added a command to toggle the braille viewer; there is no default associated gesture. (#13258)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@CyrilleB79 CyrilleB79 requested review from a team as code owners January 21, 2022 15:07
@AppVeyorBot

This comment has been minimized.

@CyrilleB79 CyrilleB79 marked this pull request as draft January 21, 2022 15:40
@CyrilleB79 CyrilleB79 marked this pull request as ready for review January 21, 2022 15:45

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@AppVeyorBot

This comment has been minimized.

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User Guide change is consistent with other similar comments in other places in the User Guide, good work!

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@seanbudd seanbudd force-pushed the toggleBrailleViewer branch from 5071a78 to 4725bcc Compare January 28, 2022 01:34
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 901f0229c0

@seanbudd seanbudd merged commit cb80dad into nvaccess:master Jan 28, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 28, 2022
@CyrilleB79 CyrilleB79 deleted the toggleBrailleViewer branch January 28, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start and stop Braille viewer via a configurable command/Input Gesture

5 participants