Remove deprecated loadState and saveState from addonHandler#13245
Merged
seanbudd merged 3 commits intoJan 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Removes code deprecated as part of PR #12792
Summary of the issue:
PR #12792 converted state in
addonHandlerto a class deprecating some module level functions in the process.Description of how this pull request fixes the issue:
Deprecated
loadStateandsaveStateare removed fromaddonHandler.Testing strategy:
With git grep made sure that these functions are not used anywhere in the source code.
Known issues with pull request:
None known
Change log entries:
For Developers
loadStateandsaveStateare removed fromaddonHandler- please useaddonHandler.state.loadandaddonHandler.state.saveinstead.Code Review Checklist: