Remove deprecated constants from languageHandler#13144
Merged
seanbudd merged 2 commits intonvaccess:masterfrom Dec 8, 2021
Merged
Remove deprecated constants from languageHandler#13144seanbudd merged 2 commits intonvaccess:masterfrom
seanbudd merged 2 commits intonvaccess:masterfrom
Conversation
seanbudd
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None. Removes code marked as deprecated in #12753
Summary of the issue:
As part of #12753 various constants in
languageHandlerwere moved into an enum but kept at the module level for backwards compatibility. Since NVDA 2022.1 is a backwards compatibility breaking release it makes sense to remove them.Description of how this pull request fixes the issue:
Deprecated constants are removed.
Testing strategy:
Made sure that removed constants are not used directly in the code.
Known issues with pull request:
None known
Change log entries:
For Developers
LOCALE_SLANGUAGE,LOCALE_SLISTandLOCALE_SLANGDISPLAYNAMEare removed fromlanguageHandler- use members oflanguageHandler.LOCALE` instead (Ensure that NVDA sets Python locale to a valid Windows locale when initializing language. #12753 )Code Review Checklist: