Skip to content

Remove deprecated constants from languageHandler#13144

Merged
seanbudd merged 2 commits intonvaccess:masterfrom
lukaszgo1:languageHandlerNoDeprecatedConstants
Dec 8, 2021
Merged

Remove deprecated constants from languageHandler#13144
seanbudd merged 2 commits intonvaccess:masterfrom
lukaszgo1:languageHandlerNoDeprecatedConstants

Conversation

@lukaszgo1
Copy link
Copy Markdown
Contributor

Link to issue number:

None. Removes code marked as deprecated in #12753

Summary of the issue:

As part of #12753 various constants in languageHandler were moved into an enum but kept at the module level for backwards compatibility. Since NVDA 2022.1 is a backwards compatibility breaking release it makes sense to remove them.

Description of how this pull request fixes the issue:

Deprecated constants are removed.

Testing strategy:

Made sure that removed constants are not used directly in the code.

Known issues with pull request:

None known

Change log entries:

For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner December 7, 2021 15:28
@lukaszgo1 lukaszgo1 requested a review from seanbudd December 7, 2021 15:28
@seanbudd seanbudd merged commit 10adc8b into nvaccess:master Dec 8, 2021
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Dec 8, 2021
@lukaszgo1 lukaszgo1 deleted the languageHandlerNoDeprecatedConstants branch December 8, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants