Skip to content

clean up getTextFromIAccessible#13127

Merged
feerrenrut merged 13 commits into
masterfrom
cleanGetTextFromIAccessible
Jan 28, 2022
Merged

clean up getTextFromIAccessible#13127
feerrenrut merged 13 commits into
masterfrom
cleanGetTextFromIAccessible

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Dec 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Depends on:

Summary of the issue:

The moved function getTextFromIAccessible doesn't use smart pointers, was missing some explicit initialization, and logic could be simplified.

Description of how this pull request fixes the issue:

  • Introduce (CCom) smart pointers.
  • Initialize all variables.
  • Simplify logic where obvious.
  • [ ] Also split based on "useNewText" Report Aria Details In Focus Mode #13106 (comment) This has been dropped. It will be kept in mind for future work in the area.

Testing strategy:

  • Builds runs locally
  • Testing with annotations changes.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot

This comment has been minimized.

Sign in to view
@feerrenrut feerrenrut mentioned this pull request Dec 9, 2021
Merged
6 tasks
@feerrenrut feerrenrut mentioned this pull request Jan 12, 2022
Merged
5 tasks
@feerrenrut feerrenrut force-pushed the cleanGetTextFromIAccessible branch from 2b71b72 to d0ced3b Compare January 13, 2022 01:59
@feerrenrut feerrenrut changed the base branch from master to addHelperForGetAccessibleChildren January 13, 2022 02:00
@AppVeyorBot

This comment has been minimized.

Sign in to view
@feerrenrut feerrenrut marked this pull request as ready for review January 16, 2022 09:45
@feerrenrut feerrenrut requested a review from a team as a code owner January 16, 2022 09:45
@feerrenrut feerrenrut requested review from seanbudd and removed request for a team January 16, 2022 09:45
Base automatically changed from addHelperForGetAccessibleChildren to master January 17, 2022 08:15
@feerrenrut feerrenrut force-pushed the cleanGetTextFromIAccessible branch from d0ced3b to 21cf41a Compare January 17, 2022 08:19
michaelDCurran
michaelDCurran requested changes Jan 25, 2022
View reviewed changes
Comment thread nvdaHelper/remote/textFromIAccessible.cpp
Comment thread nvdaHelper/remote/textFromIAccessible.cpp Outdated
@michaelDCurran

michaelDCurran commented Jan 25, 2022 via email

Copy link
Copy Markdown
Member

@feerrenrut feerrenrut merged commit 9fd8262 into master Jan 28, 2022
@feerrenrut feerrenrut deleted the cleanGetTextFromIAccessible branch January 28, 2022 08:50
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.1

Development

Successfully merging this pull request may close these issues.

5 participants

@feerrenrut @AppVeyorBot @michaelDCurran @seanbudd @nvaccessAuto