Windows 11 emoji panel: do not let NVDA assign arrow keys to search field scripts#13107
Merged
Conversation
…panel app module and text input host (newer emoji panel). Re nvaccess#13104
In newer revisions of Windows 11 (build 22000), when Windows+Period is pressed to open emoji panel, emoji search field gets focused. In order to move around the panel, one must pass the arrow keys to the application (NVDA+F2, followed by pressing the arrow key), caused by editable text scripts assigned to arrow keys (navigating by character/line). Therefore remove editable text overlay class for the emoji search field which then allows users to use the arrow keys to review emojis.
|
it is Ok. I think that it is OK. |
LeonarddeR
approved these changes
Dec 1, 2021
seanbudd
approved these changes
Jan 13, 2022
Contributor
Author
|
@seanbudd, ping, milestone update please i.e. when do you expect this will be merged into master. Thanks. |
feerrenrut
approved these changes
Feb 15, 2022
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. @seanbudd is there any reason not to merge?
Member
|
@feerrenrut - no, I was just not requested as the original reviewer. merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
If the approach is okay, please merge the PR.
Link to issue number:
Closes #13104
Summary of the issue:
In Windows 11's emoji panel, users cannot use the arrow keys to navigate the emoji panel.
Description of how this pull request fixes the issue:
Removes editable text field overlay class from emoji search field so arrow keys can be used to navigate the emoji panel, along with performing general lint.
Testing strategy:
Manual testing on Windows 10 and 11 to make sure emoji panel is working with the PR applied, especially more so on Windows 11. System tests would be ideal for Windows 11, although Appveyor uses Windows Server 2019 image (limited to Windows 10 Version 1809 assumptions).
Known issues with pull request:
None
Change log entries:
Bug fixes:
Or a variation of that.
Code Review Checklist:
Additional context:
I'm sure there is something better than removing editable text overlay class, and if there is, do let us now so it can be incorporated.
Thanks.