Fix-up of PR 12943 - Avoid os.path.commonPath` when comparing paths of the binaries as it does not work for files on different drives#13009
Merged
Conversation
…s to handle path's from different disks
Contributor
Author
|
cc @seanbudd Would you be able to review this? |
seanbudd
approved these changes
Oct 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13008
Summary of the issue:
PR #12943 improved code which retrieves version information for a given executable files placed in system32 under 64-bit versions of Windows. To do so it is necessary to check if path of the given binary starts with path of system32 directory for the current system. The recommended way to compare path's in a case insensitive way was
os.pathcommonPath`, however it turns out it does not work when path's are from different drives.In case of reporter of #13008 they had Office installed in a custom location probably on non system disk.
Description of how this pull request fixes the issue:
This PR simplifies the code to use standard
str.casefoldfor comparisons.Testing strategy:
Known issues with pull request:
None known
Change log entries:
None needed - regression not in a release.
Code Review Checklist: