Skip to content

Fix reading order / description spoken during quick nav#12933

Merged
feerrenrut merged 3 commits intomasterfrom
fixReadingOrder-12751
Oct 18, 2021
Merged

Fix reading order / description spoken during quick nav#12933
feerrenrut merged 3 commits intomasterfrom
fixReadingOrder-12751

Conversation

@feerrenrut
Copy link
Copy Markdown
Contributor

@feerrenrut feerrenrut commented Oct 14, 2021

Link to issue number:

fixes #12751

Summary of the issue:

When using quick nav ("h" in browse mode) to navigate to a heading nested in an article with a description, the description is announced before the heading. For quicknav and for focus changes, the most inner element should always be announced first, working outwards to provide additional context.

Using the following example:

data:text/html,<p>Start</p><article aria-describedby="desc"><h4>Test Title</h4><p id="desc">Test description</p>

With "report articles" unchecked, speech should be:
Test title heading level 4

Instead it was:
Test description Test title heading level 4

With "report articles" checked, speech was:
Test title heading level 4 article test description

Description of how this pull request fixes the issue:

  • Adds a test for quick nav reporting and focus changed reporting. The target element is a child node of a container that is usually spoken.
  • Don't speak description for the container unless it is an aria-description.

Testing strategy:

System tests

Known issues with pull request:

Is aria-description doing the right thing in this case?

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut force-pushed the fixReadingOrder-12751 branch from 8a420f5 to d726a85 Compare October 14, 2021 08:30
@AppVeyorBot

This comment has been minimized.

@feerrenrut feerrenrut force-pushed the fixReadingOrder-12751 branch 2 times, most recently from 05c1009 to 2e09c7b Compare October 14, 2021 09:17
@feerrenrut feerrenrut force-pushed the fixReadingOrder-12751 branch from 2e09c7b to e89c3eb Compare October 15, 2021 07:34
@feerrenrut feerrenrut mentioned this pull request Oct 15, 2021
5 tasks
@feerrenrut feerrenrut marked this pull request as ready for review October 18, 2021 02:18
@feerrenrut feerrenrut requested a review from a team as a code owner October 18, 2021 02:18
@feerrenrut feerrenrut requested a review from seanbudd October 18, 2021 02:18
@feerrenrut feerrenrut merged commit f2bb38c into master Oct 18, 2021
@feerrenrut feerrenrut deleted the fixReadingOrder-12751 branch October 18, 2021 08:26
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect reading order in web navigation with latest alpha versions

5 participants