Fix reading order / description spoken during quick nav#12933
Merged
feerrenrut merged 3 commits intomasterfrom Oct 18, 2021
Merged
Fix reading order / description spoken during quick nav#12933feerrenrut merged 3 commits intomasterfrom
feerrenrut merged 3 commits intomasterfrom
Conversation
8a420f5 to
d726a85
Compare
This comment has been minimized.
This comment has been minimized.
05c1009 to
2e09c7b
Compare
2e09c7b to
e89c3eb
Compare
michaelDCurran
approved these changes
Oct 16, 2021
seanbudd
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #12751
Summary of the issue:
When using quick nav (
"h"in browse mode) to navigate to a heading nested in an article with a description, the description is announced before the heading. For quicknav and for focus changes, the most inner element should always be announced first, working outwards to provide additional context.Using the following example:
data:text/html,<p>Start</p><article aria-describedby="desc"><h4>Test Title</h4><p id="desc">Test description</p>With "report articles" unchecked, speech should be:
Test title heading level 4Instead it was:
Test description Test title heading level 4With "report articles" checked, speech was:
Test title heading level 4 article test descriptionDescription of how this pull request fixes the issue:
Testing strategy:
System tests
Known issues with pull request:
Is aria-description doing the right thing in this case?
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: