Fixup of pr 12925: errors due to delayed spelling detection when pressing tab sometimes#12931
Merged
Conversation
…any exception not just RuntimeError as a lot of complex things could go wrong if the underlying object disappears for instance.
seanbudd
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12930
Fixup of #12925
Summary of the issue:
When fetching the formatting of the last typed word after a delay, in order to detect if there is a spelling error, errors can occur if the underlying object dies or is replaced.
For example:
when first pressing tab in the Firefox profile selection dialog:
Description of how this pull request fixes the issue:
Catch Exception rather than RuntimeError when fetching formatting by calling GetTextWithFields.
Note that this exception will still be logged at debug warning.
Testing strategy:
firefox -profilemanagerand pressed tab. Ensured that the NVDA error sound was not played but the error was still logged at debugWarning.Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: