Treat tables with 1 col or 1 row as layout tables in Outlook message viewer#12857
Merged
Conversation
…uppressing reporting when reading emails.
Member
Author
|
@LeonarddeR Your testing of this pr would be most welcome. |
Contributor
Why not say "tables containing only one row or column"? |
seanbudd
approved these changes
Sep 17, 2021
LeonarddeR
approved these changes
Sep 17, 2021
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Works great for me. Data tables are properly read whereas most layout tables I've seen are properly silenced. I think I've seen one table that was incorrectly treated as data table compared to at least 50 where all was ok.
| - NVDA no longer treats the value of UIA sliders as always percentage based. | ||
| - Reporting the location of a cell in Microsoft Excel when accessed via UI Automation again works correctly on Windows 11. (#12782) | ||
| - NVDA no longer sets invalid Python locales. (#12753) | ||
| - When reading emails in Outlook via UI Automation, reporting of tables is now suppressed by default. (#11430) |
Collaborator
There was a problem hiding this comment.
I think this one should go away in favour of the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11430
Replaces #12820
Summary of the issue:
Microsoft Outlook uses a Microsoft word document control to present emails when both reading and composing. NVDA is in the process of switching to using UI Automation to access Microsoft Word document controls due to major performance advantages, and also due to Microsoft no longer maintaining the Office object model.
However, in the UI automation implementation exposed by MS Word document controls, it is impossible to identify the difference between a data table and a layout table. Thus, NVDa reports all layout tables when reading, which is extremely annoying, as the majority of HTML emails use many nested layout tables.
Description of how this pull request fixes the issue:
Tables are now classed as layout tables in MS Word document controls if the app is Outlook, and the table is read-only (Outlook is in message reading view) and the table only has either 1 column or 1 row.
Testing strategy:
With use UIA in MS Word controls enabled in NVDA's advanced settings:
• Create a table in Microsoft Word and ensure that NVDA still reports it (number of rows / columns, cell's row and column number etc).
• Create a table in Microsoft Outlook composition view and ensure that NVDA still reports it (number of rows / columns, cell's row and column number etc).
• Open an HTML email in Outlook that has layout tables, and ensure that the table is not reported when moving into and through the table's content with the arrow keys.
Known issues with pull request:
Treating tables with 1 column or 1 row as layout tables catches a good majority of layout tables. However, there will still be a few that will not be (they might have 2 columns say). However, the choice to suppress all tables in #12820 was not popular.
Change log entries:
Bug fixes
Code Review Checklist: