MS Word with UIA: ensure document is appropriately scrolled when programmatically setting the caret#12851
Merged
Merged
Conversation
…t position, ensure that the document is scrolled such that the range is visible on screen.
Closed
9 tasks
seanbudd
approved these changes
Sep 16, 2021
Co-authored-by: Sean Budd <sean@nvaccess.org>
Contributor
|
Could this be a fix for #12855? |
Contributor
|
I also want to know if #12855 is related to this and can it be fixed? |
This was referenced Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9611
Replaces #12829
Summary of the issue:
In Microsoft Word with UIA enabled, the caret may fail to move to the right position when updated programmatically, if the new position is currently off-screen.
Specifically:
Description of how this pull request fixes the issue:
WordDocumentTextInfo's
updateCaretandupdateSelectionmethods now ensure that the document is currently scrolled such that the text range is visible on screen.Testing strategy:
@Qchristensen has confirmed that issue #9611 has been fixed by testing say all in focus mode, and say all, quick nav and arrow keys in browse mode.
Known issues with pull request:
This specifically addresses browse mode scrolling issues in MS Word with UIA enabled as these scrolling issues were also affecting syncing of the focus mode caret with the browse mode caret. But there remains scrolling issues in other apps, which have always existed. Pr #9919 goes much further in addressing all of these, but is rather complex and requires a lot more review and testing. This particular pr is much smaller and stays specific to what we need to unblock enabling UIA by default in MS Word.
Change log entries:
Bug fixes:
Code Review Checklist: