Excel with UIA: Silence redundant selected announcement for focused cells#12840
Merged
Conversation
michaelDCurran
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12530
Summary of the issue:
With UIA enabled for MS Excel, NVDA redundantly announces selected for every selected cell in Excel when it receives focus
Description of how this pull request fixes the issue:
In at least some versions of Excel, the selection pattern reports 0 selected items, even though the focused UIA element reports as selected. NVDA only silences the positive SELECTED state when one item is selected. Therefore, by discarding both the SELECTED and SELECTABLE states, we eliminate the redundant selection announcement.
Testing strategy:
Tested str from #12530
Known issues with pull request:
None known
Change log entries:
Bug fixes
Code Review Checklist: