Skip to content

Excel with UIA: Silence redundant selected announcement for focused cells#12840

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
LeonarddeR:excelUIA
Sep 13, 2021
Merged

Excel with UIA: Silence redundant selected announcement for focused cells#12840
michaelDCurran merged 2 commits into
nvaccess:masterfrom
LeonarddeR:excelUIA

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Sep 13, 2021

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #12530

Summary of the issue:

With UIA enabled for MS Excel, NVDA redundantly announces selected for every selected cell in Excel when it receives focus

Description of how this pull request fixes the issue:

In at least some versions of Excel, the selection pattern reports 0 selected items, even though the focused UIA element reports as selected. NVDA only silences the positive SELECTED state when one item is selected. Therefore, by discarding both the SELECTED and SELECTABLE states, we eliminate the redundant selection announcement.

Testing strategy:

Tested str from #12530

Known issues with pull request:

None known

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • API is compatible with existing addons.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@LeonarddeR LeonarddeR requested a review from a team as a code owner September 13, 2021 17:17
@michaelDCurran michaelDCurran merged commit 3f956a8 into nvaccess:master Sep 13, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Sep 13, 2021
@LeonarddeR LeonarddeR deleted the excelUIA branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA announces selected for every cell when UIA is enabled in Microsoft Excel

3 participants