Improve variable naming and remove exception handling when setting language in core.main#12837
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Sep 13, 2021
Merged
Conversation
seanbudd
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up from #12753
Summary of the issue:
During debugging for PR #12753 some issues in code around setting language in
core.mainbecome evident. In particular:wx.Localeobject was calledlocaleeffectively shadowing built-in Python module. While normally there is no reason to havelocaleimported in that scope if it is necessary for debugging the name is rather unfortunate.exceptaround importinglanguageHandlerand setting language was too broad hiding eventual issues.Description of how this pull request fixes the issue:
localewas renamed towxLocaleObj.languageHandlerand setting language - if any of these fails NVDA is non functional and the exception should propagate.Testing strategy:
Ensured that NVDA still starts. Existing unit tests making sure that
languageHandleris importable and that the process of setting language does not raise any exceptions.Known issues with pull request:
None known
Change log entries:
None needed.
Code Review Checklist: