Split script for reading status bar into two - one for reading and one for moving review cursor into its location#12771
Conversation
… cursor to its location - create a second command for that
seanbudd
left a comment
There was a problem hiding this comment.
Thanks @lukaszgo1, LGTM, just added some changes to make the formatting more consistent.
What are your thoughts on binding the "move cursor to location" script to pressing the keys a forth time? I think it overloads the input gesture but if there is an argument to preserve the current behaviour somehow it might be helpful.
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Thanks for these - applied now.
For scripts in general I agree that would be a good idea but not in this specific case since third press of that command copies to the clipboard potentialy overwriting whatever was there before. That forces users to be very conscious and use the forth press only when content of the clipboard is not important to them. I would prefer not to introduce this level of complexity. |
|
@Qchristensen Since this change is similar to the one I did in #10973 would you be able to comment about eventual impact to the NVDA's training material / certification? |
Qchristensen
left a comment
There was a problem hiding this comment.
Changes to the user guide at least look fine, good work!
@lukaszgo1 Thanks for thinking of the training material! The change doesn't cause any immediate issues, the training material covers using the keystroke to read the status bar, but doesn't mention what it does with the review cursor. As most users would assume it doesn't move the review cursor, this change actually lessons the need for specifically needing to cover that.
It would be worth mentioning the new command and the ability to press this more than once and I've made a note to look at that, thanks!
Link to issue number:
Closes #8600
Implements part of #7314
Summary of the issue:
Currently when reading status bar with NVDA+END review cursor is unconditionally moved to its location. This is inconsistent with all other commands for retrieving information and aside from that is extremely annoying for people working with review cursor now following the caret (I've been in a situation in which I've left review cursor somewhere either because I wanted to monitor a given object for changes, or because I was following some documentation with review cursor in a separate window and wanted to avoid unnecessary alt tabbing and lost my review position because I had to check something on a status bar countless times).
Description of how this pull request fixes the issue:
Review cursor is no longer moved to the location of the status bar. There is a separate script (no gesture assigned by default) which moves review cursor there. As described in #7314 I took this opportunity to split script for reading status bar into a separate ones for reading, spelling and copying.
Testing strategy:
With NVDA+end made sure that first press still reads, second spells and third copies. Made sure that after each of these operations review cursor has not been moved. Tested each of the newly introduced scripts made sure they work. Compiled user guide - ensured it renders as expected.
Known issues with pull request:
None known
Change log entries:
Changes:
Code Review Checklist: