Revert "Remove ignoreEditableText param"#12766
Conversation
This reverts commit 6262596.
See test results for failed build of commit cd95ffa236 |
|
I suspect this bug has something to do with the "controlStack" parameter and whether it should hold |
|
I would prefer to revert this for the moment, as it is causing a
significant bug both in Google Docs and thunderbird. By all means though
we should continue to try and better understand this / come up with a
better fix as soon as we can.
|
|
Yes, to fix this on alpha while we are working on investigating it, let's revert. But could you also add a system test to cover this case? Then when we are working on it we can be sure we don't re-introduce this specific problem. |
Co-authored-by: Sean Budd <sean@nvaccess.org>
See test results for failed build of commit bab14c34bf |
This reverts commit 6262596.
In issue #12746 it was reported that moving by paragraph in Google Docs in Google Chrome would sometimes result in NVDA saying "blank" for certain paragraphs.
Similarly although not noted in an issue yet, Some lines in Thunderbird message composition windows would also say blank.
These regressions were found to be caused by the merging of pr #12500
Further investigation found that the specific commit in the pr that caused this was 6262596
I'm not entirely sure on why this commit causes the regression, however my understanding is that this commit was only to improve readability / understanding of logic along the way and that the actual feature introduced by the pr had no dependency on this commit as such.
Thus, this pr reverts that single commit, and therefore fixes #12746.
Perhaps the logic of this commit can be better investigated at a later stage, but for now it is better to return to what we know works.