Skip to content

Emergency fix for #12523: import Hid class in hwIo package#12686

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
LeonarddeR:fix12523
Jul 26, 2021
Merged

Emergency fix for #12523: import Hid class in hwIo package#12686
michaelDCurran merged 1 commit into
nvaccess:masterfrom
LeonarddeR:fix12523

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

Link to issue number:

#12523

Summary of the issue:

#12523 stores the Hid class in its own submodule of hwIo, thereby breaking drivers relying on Hid as well as backwards compatibility.

Description of how this pull request fixes the issue:

Import Hid in hwIo package

Testing strategy:

Tested that the handy tech Braille driver works again

Known issues with pull request:

None known

Change log entries:

None needed

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@LeonarddeR LeonarddeR requested a review from a team as a code owner July 26, 2021 12:45
@LeonarddeR LeonarddeR requested a review from seanbudd July 26, 2021 12:45

@michaelDCurran michaelDCurran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@michaelDCurran michaelDCurran merged commit c5d301d into nvaccess:master Jul 26, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Jul 26, 2021
@LeonarddeR LeonarddeR deleted the fix12523 branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants