Don't leave focus mode if focused on a grid cell and user presses escape#12652
Merged
Conversation
…er presses escape Fixes #12413
Contributor
|
Please fill in the PR template. Thanks. |
Contributor
Author
|
@codeofdusk Done! |
Contributor
Author
|
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->I was attempting to help close some of the massive backlog of issues here. If each PR is going to take months to close, this task seems far less useful and I’ll take my efforts elsewhere. I don’t really wanna play the constant re-merging game.If you want to create a process that depends on getting people to sign off on a PR, please set a timeout for this process to avoid this problem in future.
|
Member
|
Thanks for your efforts in resolving the issue backlog. I agree that having a process, with automated reminders, would help us greatly reduce the PR back log that we have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12413
Summary of the issue:
See the link to the issue.
Description of how this pull request fixes the issue:
By adding the grid cell to the existing set of controls that don't process escape outside browse mode.
Testing strategy:
See https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html
Enter the grid, arrow around, hit escape, ensure that NVDA doesn't switch back to browse mode.
Known issues with pull request:
Change log entries:
Bug fixes
In ARIA data grid cells on the web, the Escape key will now be passed through to the grid and no longer turn off focus mode unconditionally. (#12413)
Code Review Checklist: