Recognize build 22000 as Windows 11#12627
Merged
Merged
Conversation
…2626. Despite the name, Windows 11 is powered by Windows 10 technologies internally (therefore major.minor is 10.0). The Windows 11 branding first appeared in build 22000 for Windows Insiders, therefore recognize 'Windows 10' build 22000 as Windows 11 (both the constant and release name were added).
…in use. Re nvaccess#12626. Construct a minimum winVersion.WinVersion class (major, minor, build) and compare it against Windows 11 information. If running Windows 11 (build 22000) or later, set release name to 'Windows 11', otherwise 'Windows 10'.
seanbudd
reviewed
Jul 9, 2021
Contributor
Author
|
Hi, of course (I thought I should add a comma…). Thanks.
|
seanbudd
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12626
Summary of the issue:
Windows 11 build 22000 is presented as "Windows 10" by NVDA.
Description of how this pull request fixes the issue:
Recognize build 22000 as Windows 11:
Testing strategy:
Manual testing:
Install Windows 11 Insider Preview (build 22000) and:
Known issues with pull request:
None
Change log entries:
Changes for developers (or perhaps a bug fix/changes):
Windows version 10.0.22000 or later is recognized as Windows 11, not Windows 10. (#12626)
Code Review Checklist:
Thanks.