Skip to content

Exit via WM_QUIT properly#12616

Merged
seanbudd merged 6 commits into
masterfrom
exit-via-wm-quit-properly
Jul 6, 2021
Merged

Exit via WM_QUIT properly#12616
seanbudd merged 6 commits into
masterfrom
exit-via-wm-quit-properly

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 5, 2021

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #12605

Summary of the issue:

Restarting NVDA by starting a new instance kills the existing process via WM_QUIT. This exits NVDA by exiting the main loop without exiting NVDA properly. We currently add an event to shutdown properly to the event queue, but the shutdown continues without waiting for that to complete.

Description of how this pull request fixes the issue:

This pumps the event queue before continuing if exiting via WM_QUIT to ensure the shutdown happens properly.

Testing strategy:

Install the PR build for this and try restarting with Ctrl+alt+N. Tested also with subsequent runnvda.bat calls.

Known issues with pull request:

None

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit ca0d74fca6

@seanbudd seanbudd marked this pull request as ready for review July 5, 2021 08:00
@seanbudd seanbudd requested a review from a team as a code owner July 5, 2021 08:00
@seanbudd seanbudd requested a review from michaelDCurran July 5, 2021 08:00
@seanbudd seanbudd merged commit 3d04197 into master Jul 6, 2021
@seanbudd seanbudd deleted the exit-via-wm-quit-properly branch July 6, 2021 01:51
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate system tray icons with NVDA 2021.1beta5

4 participants