Exit via WM_QUIT properly#12616
Merged
Merged
Conversation
See test results for failed build of commit ca0d74fca6 |
michaelDCurran
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12605
Summary of the issue:
Restarting NVDA by starting a new instance kills the existing process via WM_QUIT. This exits NVDA by exiting the main loop without exiting NVDA properly. We currently add an event to shutdown properly to the event queue, but the shutdown continues without waiting for that to complete.
Description of how this pull request fixes the issue:
This pumps the event queue before continuing if exiting via WM_QUIT to ensure the shutdown happens properly.
Testing strategy:
Install the PR build for this and try restarting with Ctrl+alt+N. Tested also with subsequent
runnvda.batcalls.Known issues with pull request:
None
Change log entries:
Bug fixes
Code Review Checklist: