Conversation
michaelDCurran
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #11103
Summary of the issue:
When using quick keys to navigate articles on a web page, the article text/label should be announced first and then "article" should be announced after it in order to streamline the browsing process.
Description of how this pull request fixes the issue:
As discussed here - #12277 (review)
ROLE_ARTICLEis determined to be aPRESCAT_CONTAINERviagetPresentationCategoryifreportArticlesis enabled. The condition in determiningspeakContentFirst,presCat != attrs.PRESCAT_CONTAINERhas been replaced withpresCat != attrs.PRESCAT_CONTAINER or role == controlTypes.ROLE_ARTICLE.The logic to determine
speakContentFirsthas been moved to a helper function as it is documented that we need to reduce the complexity ofgetControlFieldSpeech.Testing strategy:
Manually tried it out on web pages. Example websites can be found on this issue #9227
Unit testing seems unhelpful for the new helper function, however system tests for reading articles might be helpful if reviewers think so.
Known issues with pull request:
None
Change log entries:
Changes
- If article is enabled in the user preferences for document formatting, NVDA announces "article" after the content. (#11103)Code Review Checklist: