Skip to content

Announce article after content#12582

Merged
seanbudd merged 3 commits into
masterfrom
fix-11103
Jun 30, 2021
Merged

Announce article after content#12582
seanbudd merged 3 commits into
masterfrom
fix-11103

Conversation

@seanbudd

@seanbudd seanbudd commented Jun 24, 2021

Copy link
Copy Markdown
Member

Link to issue number:

Closes #11103

Summary of the issue:

When using quick keys to navigate articles on a web page, the article text/label should be announced first and then "article" should be announced after it in order to streamline the browsing process.

Description of how this pull request fixes the issue:

As discussed here - #12277 (review)
ROLE_ARTICLE is determined to be a PRESCAT_CONTAINER via getPresentationCategory if reportArticles is enabled. The condition in determining speakContentFirst, presCat != attrs.PRESCAT_CONTAINER has been replaced with presCat != attrs.PRESCAT_CONTAINER or role == controlTypes.ROLE_ARTICLE.

The logic to determine speakContentFirst has been moved to a helper function as it is documented that we need to reduce the complexity of getControlFieldSpeech.

Testing strategy:

Manually tried it out on web pages. Example websites can be found on this issue #9227

Unit testing seems unhelpful for the new helper function, however system tests for reading articles might be helpful if reviewers think so.

Known issues with pull request:

None

Change log entries:

Changes
- If article is enabled in the user preferences for document formatting, NVDA announces "article" after the content. (#11103)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd requested a review from michaelDCurran June 24, 2021 02:59
@seanbudd seanbudd requested a review from a team as a code owner June 24, 2021 02:59
@seanbudd seanbudd merged commit c438163 into master Jun 30, 2021
@seanbudd seanbudd deleted the fix-11103 branch June 30, 2021 02:51
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA announces "Article" before every article while browsing the articles via quick keys

3 participants