Use pre-processed cldr production data#12422
Merged
Merged
Conversation
…ta, which replaces all the ↑↑↑ with values from the parent locale.
Contributor
|
Hi, I assume a plan will be in place to move to using CLDR release branch once the staging branch is merged into it? Thanks.
|
Member
Author
|
Release branch?
I didn't know about that one... if that exists we should use that, yes.
Let me look...
|
Contributor
|
Hi, I assume CLDR master branch serves as release branch. Thanks.
|
Member
Author
|
cldr-staging contains tags for the official release commits, with annotations having been pre-processed. We are on tag release-39. I think this is as official as we can get. |
Contributor
|
Hi, yep makes sense (thanks for clarifying).
|
seanbudd
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11963
Summary of the issue:
Some time around CLDR release 36, CLDR started including "↑↑↑" in annotation values as a placeholder which meant that the value should be inherited from a parent locale.
These ↑↑↑ values were being put straight into NVDA's cldr dictionaries without any further processing, causing languages such as Chinese (Hongkong) and others to speak these ↑↑↑ values instead of useful emoji labels.
Description of how this pull request fixes the issue:
NVDA now includes the cldr-staging repository as a submodule, rather than the cldr repository. The cldr-staging repository contains a production directory, with all its xml files pre-processed to include inherited values rather than the ↑↑↑ placeholders.
Testing strategy:
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
NVDA will no longer announce "↑↑↑" for emojis in particular languages.
For Developers
Code Review Checklist: