move/remove imports to prevent circular dependencies#12404
Merged
Conversation
See test results for failed build of commit 73fdb7b609 |
feerrenrut
suggested changes
May 13, 2021
seanbudd
commented
May 14, 2021
feerrenrut
reviewed
May 14, 2021
feerrenrut
reviewed
May 14, 2021
feerrenrut
previously approved these changes
May 17, 2021
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Please update the target to beta, and merge. We'll need to do another beta to master merge soon.
feerrenrut
suggested changes
May 17, 2021
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
The diff includes unrelated stuff from master (Eg the CLDR changes). You'll need to rebase.
721437d to
87ae1ea
Compare
2fb0ab2 to
e0536d9
Compare
Member
Author
|
@feerrenrut I'm unable to merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12399
Summary of the issue:
NVDA fails to uninstall addons which import
guidue to a circular dependency going from speech.py -> sayAll.pyWhile the refactor of speech/sayAll #12251 was designed to make fixing this problem simpler, it did not actually fix this issue.
Description of how this pull request fixes the issue:
Testing strategy:
Manual testing that #12399 is fixed
Known issues with pull request:
none
Change log entries:
None needed
Code Review Checklist: