Fix-up of PR #11402: Redeem the copyright holders' names for source/gui/inputGestures.py after its split from source/gui/settingsDialogs.py#12386
Conversation
…`source/gui/inputGestures.py` after its split from `source/gui/settingsDialogs.py`
seanbudd
left a comment
There was a problem hiding this comment.
Thanks for catching this, I've referenced this with the contributors list on settingsDialog as well and looks good. I've suggested to remove the 2 NV Access developers though.
|
With admittedly low priority, I'm working on a script to try blame all the revisions of the given range, including those eventually fully superseded. |
lukaszgo1
left a comment
There was a problem hiding this comment.
@seanbudd Since as part of different PR I've verified that the list of contributors is accurate here can we consider applying my suggestion below and merge this? While I agree that having completely precise copyright headers for moved code is not horribly important if we have an complete list it seems a waste not to use it and prefer to use an entire (likely also not completely accurate) header from gui\settingsDialogs.
| # -*- coding: UTF-8 -*- | ||
| # A part of NonVisual Desktop Access (NVDA) | ||
| # Copyright (C) 2020 NV Access Limited | ||
| # Copyright (C) 2013-2020 NV Access Limited, James Teh, Zahari Yurukov, Joseph Lee, Reef Turner, |
There was a problem hiding this comment.
When working on #13294 I've verified that the copyright header herer is accurate, though it seems we don't include names of NV Access employees.
| # Copyright (C) 2013-2020 NV Access Limited, James Teh, Zahari Yurukov, Joseph Lee, Reef Turner, | |
| # Copyright (C) 2013-2020 NV Access Limited, Zahari Yurukov, Joseph Lee, |
See test results for failed build of commit 49ea743a24 |
See test results for failed build of commit 49ea743a24 |
See test results for failed build of commit ad3fb10987 |
Link to issue number:
Fix-up of PR #11402
Summary of the issue:
In PR #11402, part of
source/gui/settingsDialogs.pyhas been extracted to the newsource/gui/inputGestures.pyfor good reasons.However, in the process, the name of the copyright holders for this portion of the code has not been reported to the header of the new file.
Description of how this pull request fixes the issue:
Copy all the names from the copryright headers in
source/gui/settingsDialogs.py.Testing strategy:
Known issues with pull request:
Change log entries:
Code Review Checklist: