Fix-up of 12025: No longer fail to report content of nonfocused text fields in Firefox#12319
Merged
Merged
Conversation
Contributor
Author
michaelDCurran
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12114
Summary of the issue:
PR #12025 started catching only very specific exceptions when getting selection of edit fields. However in Firefox attempting to get caret for non focused edit fields results in RuntimeError which made it impossible to speak these controls.
Description of how this pull request fixes the issue:
When getting content of edit fields were catching RuntimeError as well and threading this situation like no selection.
Testing strategy:
Ensured that STR from #12114 is no longer reproducible
Ensured that error sound no longer plays each time when accepting autocomplete in Firefox address bar
This code cannot be unit tested and we do not have system tests for Firefox.
Known issues with pull request:
None known
Change log entries:
None needed - bug not in a release.
Code Review Checklist: