Follow up of PR 12250: Use FILETIME from winKernel rather than define it multiple times.#12312
Merged
feerrenrut merged 5 commits intonvaccess:masterfrom Apr 21, 2021
Merged
Conversation
…r than defining it in every file.
- Do not rely on star imports. It has been necessary to do it for sapi4 since it star imported everything from the internal module and therefore stopped working after internal module has been linted.
- Standardize copyright header. - Do not rely on star imports from ctypes
feerrenrut
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, follow up from PR #12250
Summary of the issue:
PR #12250 added definition of
FILETIMEstructure from Windows.h to the winKernel module. This structure was already used throout NVDA's source code but it was defined in every file in which it was used. It makes sense to define it just once in winKernel and use from there.Description of how this pull request fixes the issue:
For both
objidland_sapi4the definition forFILETIMEhas been removed and every usage has been replaced with the definition from winKernel.To comply with the style enforced by Linter it was necessary to fix star imports in
_sapi4which also necessitated fixing them in the main SAPI4 driver since it imported everything from the private driver and therefore stopped working after linting,.Testing strategy:
Ensured that SAPI4 still works.
with git grep ensured that no usages of
FILETIMEwere missed.Known issues with pull request:
None known,
Change log entries:
I don't think this deserves change log entry.
Code Review Checklist: