Restore advanced settings layout.#12223
Merged
michaelDCurran merged 1 commit intoMar 25, 2021
Merged
Conversation
7 tasks
michaelDCurran
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Issue described in #12210 (comment)
Summary of the issue:
The new option introduced by #12210 is not located in the "Microsoft UI Automation" option group as it should.
Probably due to missed changes during upmerge of master.
Description of how this pull request fixes the issue:
Put it in this group as intended.
The static box of the sizer should be used as parent for the checkbox rather than the whole panel.
Testing strategy:
Manual testing: checked visually that the checkbox is in the correct option group.
No unit test or system test needed for such a fix.
Known issues with pull request:
None
Change log entry:
Not needed (fix in alpha stage)
Cc @michaelDCurran, @seanbudd